Repository navigation
Give the unexpected error toast its own title - #1392
Merged
microbit-matt-hillsdon merged 2 commits intoNov 4, 2026
Merged
microbit-matt-hillsdon merged 2 commits into
microbit-matt-hillsdon merged 2 commits into
Conversation
The toast used the description message, which has a <link> tag, as its title without passing a link, so formatting failed and the title showed the raw message id. Use unexpected-error-title instead and give it real title text. The existing translations of unexpected-error-title are copies of the description, so they are removed and English shows until Crowdin has new ones. Closes microbit-foundation#1267
microbit-matt-hillsdon
approved these changes
Nov 4, 2026
microbit-matt-hillsdon
left a comment
microbit-matt-hillsdon
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks!
microbit-matt-hillsdon
merged commit Nov 4, 2026
f88b88d
into
microbit-foundation:main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1267
The unexpected error toast used
unexpected-error-descriptionas its title. That message has a<link>tag and no link was passed for the title, so formatting failed and the toast (and screen readers) showed the raw id "unexpected-error-description" as the title.unexpected-error-title, which reads "An unexpected error occurred", matching the full-page error view.unexpected-error-titlewere copies of the description,<link>and all, soi18n:tidy --checkfails once the English changes. I've removed just those entries so English shows until Crowdin has new ones. When uploading, please leave "keep translations" unticked for this string.Checked with typecheck, lint, unit tests,
i18n:tidy --check, the save, multiple-files and settings e2e tests, and a build. I also triggered the toast in the browser in English and German to confirm the title.AI-assisted.